LeMoonStar/zen-realigned
1
0
Fork 0
forked from ZenBrowserMirrors/zen-desktop
Code Pull requests Activity

fix: Fixed pinned tab icons not appearing at startup, b=(no-bug), c=tabs

Browse source
This commit is contained in:
mr. m 2025-05-28 10:17:33 +02:00
parent 5c6e5f7361
commit 18944d5ed8
No known key found for this signature in database
GPG key ID: 419302196C23B258
1 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/zen/tabs/ZenPinnedTabManager.mjs
View file

@ -90,10 +90,11 @@
onTabIconChanged(tab, url = null) { onTabIconChanged(tab, url = null) {
const iconUrl = url ?? tab.iconImage.src; const iconUrl = url ?? tab.iconImage.src;
if (!iconUrl) { if (!iconUrl && tab.hasAttribute('zen-pin-id')) {
try { try {
setTimeout(async () => { setTimeout(async () => {
try { try {
await this.promisePinnedCacheInitialized;
const pin = this._pinsCache?.find( const pin = this._pinsCache?.find(
(pin) => pin.uuid === tab.getAttribute('zen-pin-id') (pin) => pin.uuid === tab.getAttribute('zen-pin-id')
); );
@ -162,6 +163,9 @@
await gZenWorkspaces.promiseSectionsInitialized; await gZenWorkspaces.promiseSectionsInitialized;
await this._initializePinsCache(); await this._initializePinsCache();
await this._initializePinnedTabs(init); await this._initializePinnedTabs(init);
if (init) {
this._resolveInitializedPinnedCache();
}
} }
async _initializePinsCache() { async _initializePinsCache() {
@ -637,17 +641,12 @@
this.resetPinChangedUrl(tab); this.resetPinChangedUrl(tab);
} }
async getFaviconAsBase64(pageUrl, secondTry = false) { async getFaviconAsBase64(pageUrl) {
try { try {
const faviconData = await PlacesUtils.favicons.getFaviconForPage(pageUrl); const faviconData = await PlacesUtils.favicons.getFaviconForPage(pageUrl);
if (!faviconData) { if (!faviconData) {
if (secondTry || pageUrl.spec.startsWith('about:')) { // empty favicon
// empty favicon return 'data:image/png;base64,';
return 'data:image/png;base64,';
}
// Try again with the domain
const domainUrl = pageUrl.spec.substring(0, pageUrl.spec.indexOf('/'));
return await this.getFaviconAsBase64(Services.io.newURI(domainUrl), true);
} }
return faviconData.dataURI; return faviconData.dataURI;
} catch (ex) { } catch (ex) {
@ -1135,4 +1134,8 @@
} }
window.gZenPinnedTabManager = new ZenPinnedTabManager(); window.gZenPinnedTabManager = new ZenPinnedTabManager();
gZenPinnedTabManager.promisePinnedCacheInitialized = new Promise((resolve) => {
gZenPinnedTabManager._resolveInitializedPinnedCache = resolve;
});
} }