ZenBrowserMirrors/components
1
0
Fork 0
mirror of https://github.com/zen-browser/components.git synced 2025-07-07 21:39:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: Fix bug preventing ZenKeyboardShortcuts from initializing shortcuts on the browser page

Browse source
This commit is contained in:
Mauro Balades 2024-08-10 18:18:56 +02:00
parent fbde484df9
commit 3e1d38d907
1 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/ZenKeyboardShortcuts.mjs
View file

@ -167,7 +167,7 @@ var gZenKeyboardShortcuts = {
_onShortcutChange() { _onShortcutChange() {
console.info("Zen CKS: Shortcut changed"); console.info("Zen CKS: Shortcut changed");
this.__savedShortcuts = null; this.__savedShortcuts = null;
this._initSavedShortcuts(); this._initSavedShortcuts(true);
}, },
_getCommandAttribute(action) { _getCommandAttribute(action) {
@ -217,7 +217,7 @@ var gZenKeyboardShortcuts = {
`); `);
}, },
_initSavedShortcuts() { _initSavedShortcuts(fromUpdate = false) {
let keySet = document.getElementById("mainKeyset"); let keySet = document.getElementById("mainKeyset");
if (!keySet) { if (!keySet) {
throw new Error("Zen CKS: No main keyset found"); throw new Error("Zen CKS: No main keyset found");
@ -231,9 +231,22 @@ var gZenKeyboardShortcuts = {
} }
let shortcut = this._createShortcutElement(action); let shortcut = this._createShortcutElement(action);
if (shortcut) { if (shortcut) {
keySet.appendChild(shortcut); keySet.prepend(shortcut);
} }
} }
this._fixMeinKeyset();
},
_fixMeinKeyset() {
let keySet = document.getElementById("mainKeyset");
if (!keySet) {
throw new Error("Zen CKS: No main keyset found");
}
const parent = keySet.parentElement;
// We need to re-append the main keyset to the document to make the shortcuts work
keySet.remove();
parent.prepend(keySet);
}, },
getShortcut(action) { getShortcut(action) {