From 74309687ad7b132222fab8f984da4402ca9ecf5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kristijan=20Ribari=C4=87?= <kriba13@gmail.com>
Date: Sat, 21 Sep 2024 23:19:18 +0200
Subject: [PATCH] refactor(workspaces): remove unnecessary workspace
 propagation

Removes the unnecessary `_propagateWorkspaceData()` calls throughout the code,
as the data propagation is handled by the `onSyncChange()` method after saving
workspaces. This makes the code more concise and efficient.
---
 src/ZenWorkspaces.mjs | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/src/ZenWorkspaces.mjs b/src/ZenWorkspaces.mjs
index d7764b7..673f553 100644
--- a/src/ZenWorkspaces.mjs
+++ b/src/ZenWorkspaces.mjs
@@ -211,8 +211,6 @@ var ZenWorkspaces = {
     delete this._lastSelectedWorkspaceTabs[windowID];
     json.workspaces = json.workspaces.filter((workspace) => workspace.uuid !== windowID);
     this.unsafeSaveWorkspaces(json);
-    this._propagateWorkspaceData();
-    this._updateWorkspacesChangeContextMenu();
   },
 
   saveWorkspaces() {
@@ -228,6 +226,7 @@ var ZenWorkspaces = {
   onSyncChange() {
     console.info("Syncing workspaces...");
     this._propagateWorkspaceData();
+    this._updateWorkspacesChangeContextMenu();
   },
 
   // Workspaces dialog UI management
@@ -273,9 +272,9 @@ var ZenWorkspaces = {
     return workspace.name[0].toUpperCase();
   },
 
-  async _propagateWorkspaceData({
-                                  ignoreStrip = false
-                                } = {}) {
+  _propagateWorkspaceData({
+                            ignoreStrip = false
+                          } = {}) {
     let currentContainer = document.getElementById('PanelUI-zen-workspaces-current-info');
     let workspaceList = document.getElementById('PanelUI-zen-workspaces-list');
     if (!ignoreStrip) {
@@ -547,8 +546,6 @@ var ZenWorkspaces = {
     icon?.removeAttribute('selected');
     this.createAndSaveWorkspace(workspaceName, false, icon?.label);
     document.getElementById('PanelUI-zen-workspaces').hidePopup(true);
-    this._updateWorkspacesButton();
-    this._propagateWorkspaceData();
   },
 
   saveWorkspaceFromEdit() {
@@ -565,8 +562,6 @@ var ZenWorkspaces = {
     workspaceData.name = workspaceName;
     workspaceData.icon = icon?.label;
     this.saveWorkspace(workspaceData);
-    this._updateWorkspacesButton();
-    this._propagateWorkspaceData();
     this.closeWorkspacesSubView();
   },
 
@@ -762,7 +757,6 @@ var ZenWorkspaces = {
     let userContextId = parseInt(event.target.getAttribute('data-usercontextid'));
     workspace.containerTabId = userContextId;
     this.saveWorkspace(workspace);
-    this._propagateWorkspaceData();
   },
 
   onContextMenuClose() {
@@ -781,7 +775,6 @@ var ZenWorkspaces = {
       workspace.default = workspace.uuid === this._contextMenuId;
     }
     this.unsafeSaveWorkspaces(workspaces);
-    this._propagateWorkspaceData();
   },
 
   openWorkspace() {