From 7692662dd76d087ca905fa898273e0059a4dba92 Mon Sep 17 00:00:00 2001
From: mauro-balades <mauro.balades@tutanota.com>
Date: Sun, 15 Sep 2024 09:40:52 +0200
Subject: [PATCH] Refactor ZenViewSplitter to fix tab closing bug

---
 src/ZenViewSplitter.mjs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/ZenViewSplitter.mjs b/src/ZenViewSplitter.mjs
index 51494af..1bac78d 100644
--- a/src/ZenViewSplitter.mjs
+++ b/src/ZenViewSplitter.mjs
@@ -536,8 +536,9 @@ var gZenViewSplitter = new (class {
     if (this.currentView < 0) return;
     const currentTab = window.gBrowser.selectedTab;
     const tabs = this._data[this.currentView].tabs;
-    for (const tab of tabs) {
-      this.handleTabClose({ target: tab, forUnsplit: true });
+    // note: This MUST be an index loop, as we are removing tabs from the array
+    for (let i = tabs.length - 1; i >= 0; i--) {
+      this.handleTabClose({ target: tabs[i], forUnsplit: true });
     }
     window.gBrowser.selectedTab = currentTab;
     this.updateSplitViewButton(true);