ZenBrowserMirrors/components
1
0
Fork 0
mirror of https://github.com/zen-browser/components.git synced 2025-07-08 09:09:59 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor ZenKeyboardShortcuts to fix platform-specific key behavior and add l10n support

Browse source
This commit is contained in:
mauro-balades 2024-09-24 21:20:48 +02:00
parent 160e85f337
commit b10313ac47
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ZenKeyboardShortcuts.mjs
View file

@ -173,7 +173,7 @@ class KeyShortcutModifiers {
str += 'Shift+';
}
if (this.#meta) {
str += AppConstants.platform == 'macosx' ? 'Cmd+' : 'Win+';
str += AppConstants.platform == 'macosx' ? 'Meta+' : 'Win+';
}
if (this.#accel) {
if (AppConstants.platform == 'macosx') {
@ -346,7 +346,9 @@ class KeyShortcut {
// shortcuts in mind, it will siply just override the shortcuts with whatever the default is.
// note that this l10n id is not used for actually translating the key's label, but rather to
// identify the default keybinds.
key.setAttribute('data-l10n-id', this.#l10nId);
if (this.#l10nId) {
key.setAttribute('data-l10n-id', this.#l10nId);
}
key.setAttribute('modifiers', this.#modifiers.toString());
if (this.#action) {
if (this.#action?.startsWith('code:')) {