ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-10 18:25:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #12364 from calixteman/really_fix_name_issue

Browse source 
Dict keys need to be escaped too when saving
This commit is contained in:
Brendan Dahl 2020-09-11 09:55:12 -07:00 • committed by GitHub
commit 008eed0efe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/writer.js
View file

@ -23,7 +23,7 @@ import { calculateMD5 } from "./crypto.js";
function writeDict(dict, buffer, transform) { function writeDict(dict, buffer, transform) {
buffer.push("<<"); buffer.push("<<");
for (const key of dict.getKeys()) { for (const key of dict.getKeys()) {
buffer.push(` /${key} `); buffer.push(` /${escapePDFName(key)} `);
writeValue(dict.getRaw(key), buffer, transform); writeValue(dict.getRaw(key), buffer, transform);
} }
buffer.push(">>"); buffer.push(">>");

4
test/unit/writer_spec.js
View file

@ -98,14 +98,14 @@ describe("Writer", function () {
it("should write a Dict in escaping PDF names", function (done) { it("should write a Dict in escaping PDF names", function (done) {
const dict = new Dict(null); const dict = new Dict(null);
dict.set("A", Name.get("hello")); dict.set("\xfeA#", Name.get("hello"));
dict.set("B", Name.get("#hello")); dict.set("B", Name.get("#hello"));
dict.set("C", Name.get("he\xfello\xff")); dict.set("C", Name.get("he\xfello\xff"));
const buffer = []; const buffer = [];
writeDict(dict, buffer, null); writeDict(dict, buffer, null);
const expected = "<< /A /hello /B /#23hello /C /he#fello#ff>>"; const expected = "<< /#feA#23 /hello /B /#23hello /C /he#fello#ff>>";
expect(buffer.join("")).toEqual(expected); expect(buffer.join("")).toEqual(expected);
done(); done();