ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 01:10:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Collect all l10n fallback strings, used in the viewer, in one helper function (PR 12981 follow-up)

Browse source 
Rather than having to spell out the English fallback strings at *every* single `IL10n.get` call-site throughout the viewer, we can simplify things by collecting them in *one* central spot.
This provides a much better overview of the fallback l10n strings used, which makes future changes easier and ensures that fallback strings occuring in multiple places cannot accidentally get out of sync.
Furthermore, by making the `fallback` parameter of the `IL10n.get` method *optional*[1] many of the call-sites (and their surrounding code) become a lot less verbose.

---
[1] It's obviously still possible to pass in a fallback string, it's just not required.
This commit is contained in:
Jonas Jenwald 2021-02-22 12:43:16 +01:00
parent 8d203b3039
commit 038668bf8c
17 changed files with 238 additions and 272 deletions
Download patch file Download diff file Expand all files Collapse all files

2
web/annotation_layer_builder.js
View file

@ -14,7 +14,7 @@
*/
import { AnnotationLayer } from "pdfjs-lib";
import { NullL10n } from "./ui_utils.js";
import { NullL10n } from "./l10n_utils.js";
import { SimpleLinkService } from "./pdf_link_service.js";
/**