ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-10 18:25:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Support FileAttachments with hash-signs in the filename (issue 15729)

Browse source 
The reason for the issue is that we use the generic `getFilenameFromUrl` helper function, which was originally intended for regular URLs.
For the filenames we're dealing with in FileAttachments, we really only want to strip the path when one exists[1].

---
[1] See [bug 1230933](https://bugzilla.mozilla.org/show_bug.cgi?id=1230933) for an example of such a case.
This commit is contained in:
Jonas Jenwald 2022-11-23 10:40:30 +01:00
parent a0db81723b
commit 0ba242ea4a
4 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/display/annotation_layer.js
View file

@ -2496,7 +2496,7 @@ class FileAttachmentAnnotationElement extends AnnotationElement {
super(parameters, { isRenderable: true });
const { filename, content } = this.data.file;
this.filename = getFilenameFromUrl(filename);
this.filename = getFilenameFromUrl(filename, /* onlyStripPath = */ true);
this.content = content;
this.linkService.eventBus?.dispatch("fileattachmentannotation", {