Add better support for /Launch actions with /FileSpec dictionaries (issue 17846)

This commit is contained in:
Jonas Jenwald 2024-03-26 20:07:23 +01:00
parent 1141af9d6f
commit 0d039937f9
5 changed files with 38 additions and 9 deletions

View file

@ -1568,9 +1568,13 @@ class Catalog {
case "GoToR": case "GoToR":
const urlDict = action.get("F"); const urlDict = action.get("F");
if (urlDict instanceof Dict) { if (urlDict instanceof Dict) {
// We assume that we found a FileSpec dictionary const fs = new FileSpec(
// and fetch the URL without checking any further. urlDict,
url = urlDict.get("F") || null; /* xref = */ null,
/* skipContent = */ true
);
const { filename } = fs.serializable;
url = filename;
} else if (typeof urlDict === "string") { } else if (typeof urlDict === "string") {
url = urlDict; url = urlDict;
} }

View file

@ -42,7 +42,9 @@ function pickPlatformItem(dict) {
* collections attributes and related files (/RF) * collections attributes and related files (/RF)
*/ */
class FileSpec { class FileSpec {
constructor(root, xref) { #contentAvailable = false;
constructor(root, xref, skipContent = false) {
if (!(root instanceof Dict)) { if (!(root instanceof Dict)) {
return; return;
} }
@ -57,10 +59,12 @@ class FileSpec {
if (root.has("RF")) { if (root.has("RF")) {
warn("Related file specifications are not supported"); warn("Related file specifications are not supported");
} }
this.contentAvailable = true; if (!skipContent) {
if (!root.has("EF")) { if (root.has("EF")) {
this.contentAvailable = false; this.#contentAvailable = true;
warn("Non-embedded file specifications are not supported"); } else {
warn("Non-embedded file specifications are not supported");
}
} }
} }
@ -76,7 +80,7 @@ class FileSpec {
} }
get content() { get content() {
if (!this.contentAvailable) { if (!this.#contentAvailable) {
return null; return null;
} }
if (!this.contentRef && this.root) { if (!this.contentRef && this.root) {

View file

@ -63,6 +63,7 @@
!issue7507.pdf !issue7507.pdf
!issue6931_reduced.pdf !issue6931_reduced.pdf
!issue14847.pdf !issue14847.pdf
!issue17846.pdf
!doc_actions.pdf !doc_actions.pdf
!issue7580.pdf !issue7580.pdf
!issue7598.pdf !issue7598.pdf

BIN
test/pdfs/issue17846.pdf Normal file

Binary file not shown.

View file

@ -2926,6 +2926,26 @@ describe("api", function () {
await loadingTask.destroy(); await loadingTask.destroy();
}); });
it("gets annotations containing /Launch action with /FileSpec dictionary (issue 17846)", async function () {
const loadingTask = getDocument(buildGetDocumentParams("issue17846.pdf"));
const pdfDoc = await loadingTask.promise;
const pdfPage = await pdfDoc.getPage(1);
const annotations = await pdfPage.getAnnotations();
expect(annotations.length).toEqual(1);
const { annotationType, url, unsafeUrl, newWindow } = annotations[0];
expect(annotationType).toEqual(AnnotationType.LINK);
expect(url).toBeUndefined();
expect(unsafeUrl).toEqual(
"对不起/没关系/1_1_模块1行政文件和药品信息目录.pdf"
);
expect(newWindow).toEqual(true);
await loadingTask.destroy();
});
it("gets text content", async function () { it("gets text content", async function () {
const { items, styles } = await page.getTextContent(); const { items, styles } = await page.getTextContent();