ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 09:20:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[api-minor] Re-factor the basic textLayer-functionality

Browse source 
This is very old code, and predates e.g. the introduction of JavaScript classes, which creates unnecessarily unwieldy code in the viewer.
By introducing a new `TextLayer` class in the API, similar to how e.g. the `AnnotationLayer` looks, we're able to keep most parameters on the class-instance itself. This removes the need to manually track them in the viewer, and simplifies the call-sites.

This also removes the `numTextDivs` parameter from the "textlayerrendered" event, since that's only added to support default-viewer functionality that no longer exists.

Finally we try, as far as possible, to polyfill the old `renderTextLayer` and `updateTextLayer` functions since they are exposed in the library API.
For *simple* invocations of `renderTextLayer` the behaviour should thus be the same, with only a warning printed in the console.
This commit is contained in:
Jonas Jenwald 2024-05-16 11:28:06 +02:00
parent 63b66b412c
commit 15b5808eee
9 changed files with 383 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

24
test/driver.js
View file

@ -22,8 +22,8 @@ const {
GlobalWorkerOptions,
Outliner,
PixelsPerInch,
renderTextLayer,
shadow,
TextLayer,
XfaLayer,
} = pdfjsLib;
const { GenericL10n, parseQueryString, SimpleLinkService } = pdfjsViewer;
@ -297,13 +297,12 @@ class Rasterize {
`:root { --scale-factor: ${viewport.scale} }`;
// Rendering text layer as HTML.
const task = renderTextLayer({
const textLayer = new TextLayer({
textContentSource: textContent,
container: div,
viewport,
});
await task.promise;
await textLayer.render();
svg.append(foreignObject);
@ -327,15 +326,14 @@ class Rasterize {
`:root { --scale-factor: ${viewport.scale} }`;
// Rendering text layer as HTML.
const task = renderTextLayer({
const textLayer = new TextLayer({
textContentSource: textContent,
container: dummyParent,
viewport,
});
await textLayer.render();
await task.promise;
const { _pageWidth, _pageHeight, _textDivs } = task;
const { pageWidth, pageHeight, textDivs } = textLayer;
const boxes = [];
let j = 0,
posRegex;
@ -343,7 +341,7 @@ class Rasterize {
if (type) {
continue;
}
const { top, left } = _textDivs[j++].style;
const { top, left } = textDivs[j++].style;
let x = parseFloat(left) / 100;
let y = parseFloat(top) / 100;
if (isNaN(x)) {
@ -352,12 +350,12 @@ class Rasterize {
// string, e.g. `calc(var(--scale-factor)*66.32px)`.
let match = left.match(posRegex);
if (match) {
x = parseFloat(match[1]) / _pageWidth;
x = parseFloat(match[1]) / pageWidth;
}
match = top.match(posRegex);
if (match) {
y = parseFloat(match[1]) / _pageHeight;
y = parseFloat(match[1]) / pageHeight;
}
}
if (width === 0 || height === 0) {
@ -366,8 +364,8 @@ class Rasterize {
boxes.push({
x,
y,
width: width / _pageWidth,
height: height / _pageHeight,
width: width / pageWidth,
height: height / pageHeight,
});
}
// We set the borderWidth to 0.001 to slighly increase the size of the