mirror of
https://github.com/zen-browser/pdf.js.git
synced 2025-07-07 17:05:38 +02:00
Merge pull request #18594 from Snuffleupagus/rm-enableHighlightEditor-pref
Remove the `enableHighlightEditor` preference
This commit is contained in:
commit
17b24639b9
4 changed files with 1 additions and 18 deletions
|
@ -94,10 +94,6 @@
|
||||||
"description": "Whether to allow execution of active content (JavaScript) by PDF files.",
|
"description": "Whether to allow execution of active content (JavaScript) by PDF files.",
|
||||||
"default": false
|
"default": false
|
||||||
},
|
},
|
||||||
"enableHighlightEditor": {
|
|
||||||
"type": "boolean",
|
|
||||||
"default": false
|
|
||||||
},
|
|
||||||
"enableHighlightFloatingButton": {
|
"enableHighlightFloatingButton": {
|
||||||
"type": "boolean",
|
"type": "boolean",
|
||||||
"default": false
|
"default": false
|
||||||
|
|
|
@ -558,11 +558,6 @@ const PDFViewerApplication = {
|
||||||
typeof AbortSignal.any === "function") &&
|
typeof AbortSignal.any === "function") &&
|
||||||
annotationEditorMode !== AnnotationEditorType.DISABLE
|
annotationEditorMode !== AnnotationEditorType.DISABLE
|
||||||
) {
|
) {
|
||||||
const editorHighlightButton = appConfig.toolbar?.editorHighlightButton;
|
|
||||||
if (editorHighlightButton && AppOptions.get("enableHighlightEditor")) {
|
|
||||||
editorHighlightButton.hidden = false;
|
|
||||||
}
|
|
||||||
|
|
||||||
this.annotationEditorParams = new AnnotationEditorParams(
|
this.annotationEditorParams = new AnnotationEditorParams(
|
||||||
appConfig.annotationEditorParams,
|
appConfig.annotationEditorParams,
|
||||||
eventBus
|
eventBus
|
||||||
|
|
|
@ -200,14 +200,6 @@ const defaultOptions = {
|
||||||
value: true,
|
value: true,
|
||||||
kind: OptionKind.VIEWER + OptionKind.PREFERENCE + OptionKind.EVENT_DISPATCH,
|
kind: OptionKind.VIEWER + OptionKind.PREFERENCE + OptionKind.EVENT_DISPATCH,
|
||||||
},
|
},
|
||||||
enableHighlightEditor: {
|
|
||||||
// We'll probably want to make some experiments before enabling this
|
|
||||||
// in Firefox release, but it has to be temporary.
|
|
||||||
// TODO: remove it when unnecessary.
|
|
||||||
/** @type {boolean} */
|
|
||||||
value: typeof PDFJSDev === "undefined" || PDFJSDev.test("TESTING"),
|
|
||||||
kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
|
|
||||||
},
|
|
||||||
enableHighlightFloatingButton: {
|
enableHighlightFloatingButton: {
|
||||||
// We'll probably want to make some experiments before enabling this
|
// We'll probably want to make some experiments before enabling this
|
||||||
// in Firefox release, but it has to be temporary.
|
// in Firefox release, but it has to be temporary.
|
||||||
|
|
|
@ -363,7 +363,7 @@ See https://github.com/adobe-type-tools/cmap-resources
|
||||||
</div>
|
</div>
|
||||||
<div id="toolbarViewerRight">
|
<div id="toolbarViewerRight">
|
||||||
<div id="editorModeButtons" class="splitToolbarButton toggled" role="radiogroup">
|
<div id="editorModeButtons" class="splitToolbarButton toggled" role="radiogroup">
|
||||||
<button id="editorHighlight" class="toolbarButton" type="button" hidden="true" disabled="disabled" title="Highlight" role="radio" aria-checked="false" aria-controls="editorHighlightParamsToolbar" tabindex="31" data-l10n-id="pdfjs-editor-highlight-button">
|
<button id="editorHighlight" class="toolbarButton" type="button" disabled="disabled" title="Highlight" role="radio" aria-checked="false" aria-controls="editorHighlightParamsToolbar" tabindex="31" data-l10n-id="pdfjs-editor-highlight-button">
|
||||||
<span data-l10n-id="pdfjs-editor-highlight-button-label">Highlight</span>
|
<span data-l10n-id="pdfjs-editor-highlight-button-label">Highlight</span>
|
||||||
</button>
|
</button>
|
||||||
<button id="editorFreeText" class="toolbarButton" type="button" disabled="disabled" title="Text" role="radio" aria-checked="false" aria-controls="editorFreeTextParamsToolbar" tabindex="32" data-l10n-id="pdfjs-editor-free-text-button">
|
<button id="editorFreeText" class="toolbarButton" type="button" disabled="disabled" title="Text" role="radio" aria-checked="false" aria-controls="editorFreeTextParamsToolbar" tabindex="32" data-l10n-id="pdfjs-editor-free-text-button">
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue