ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-09 01:35:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[api-minor] Modernize and simplify the ProgressBar class

Browse source 
The original `ProgressBar`-functionality is very old, and could thus do with some general clean-up.
In particular, while it currently accepts various options those have never really been used in either the default viewer or in any examples. The sort of "styling" that these options provided are *much better*, not to mention simpler, done directly with CSS rules.

As part of these changes, the "progress" is now updated using CSS variables rather than by directly modifying the `style` of DOM elements. This should hopefully simplify future changes to this code, see e.g. PR 14898.

Finally, this also fixes a couple of other small things in the "mobile viewer" example.
This commit is contained in:
Jonas Jenwald 2022-05-14 13:10:13 +02:00
parent b5f2bd8bfd
commit 1f3da032b4
4 changed files with 32 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

8
examples/mobile-viewer/viewer.js
View file

@ -82,7 +82,9 @@ const PDFViewerApplication = {
self.pdfDocument = pdfDocument;
self.pdfViewer.setDocument(pdfDocument);
self.pdfLinkService.setDocument(pdfDocument);
self.pdfHistory.initialize({ fingerprint: pdfDocument.fingerprint });
self.pdfHistory.initialize({
fingerprint: pdfDocument.fingerprints[0],
});
self.loadingBar.hide();
self.setTitleUsingMetadata(pdfDocument);
@ -159,7 +161,7 @@ const PDFViewerApplication = {
},
get loadingBar() {
const bar = new pdfjsViewer.ProgressBar("#loadingBar", {});
const bar = new pdfjsViewer.ProgressBar("#loadingBar");
return pdfjsLib.shadow(this, "loadingBar", bar);
},
@ -187,7 +189,7 @@ const PDFViewerApplication = {
// Provides some basic debug information
console.log(
"PDF " +
pdfDocument.fingerprint +
pdfDocument.fingerprints[0] +
" [" +
info.PDFFormatVersion +
" " +