Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.

This commit is contained in:
Mark Banner 2017-05-17 10:30:46 +01:00
parent e9cbfbccb4
commit 2e9ae50a3a
24 changed files with 28 additions and 26 deletions

View file

@ -3,11 +3,20 @@
../../.eslintrc ../../.eslintrc
], ],
"env": {
"webextensions": true
},
"plugins": [
"mozilla"
],
"parserOptions": { "parserOptions": {
"sourceType": "script" "sourceType": "script"
}, },
"rules": { "rules": {
"mozilla/import-globals": "error",
"object-shorthand": "off", "object-shorthand": "off",
}, },
} }

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome, CSS */
'use strict'; 'use strict';

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome */
'use strict'; 'use strict';

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome */
'use strict'; 'use strict';

View file

@ -14,7 +14,6 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* eslint strict: ["error", "function"] */ /* eslint strict: ["error", "function"] */
/* globals chrome */
(function() { (function() {
'use strict'; 'use strict';

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome */
'use strict'; 'use strict';
var storageAreaName = chrome.storage.sync ? 'sync' : 'local'; var storageAreaName = chrome.storage.sync ? 'sync' : 'local';

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome */
'use strict'; 'use strict';

View file

@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* eslint strict: ["error", "function"] */ /* eslint strict: ["error", "function"] */
/* globals chrome, getViewerURL */ /* import-globals-from pdfHandler.js */
(function() { (function() {
'use strict'; 'use strict';

View file

@ -13,7 +13,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome, Features, saveReferer */ /* import-globals-from feature-detect.js */
/* import-globals-from preserve-referer.js */
'use strict'; 'use strict';

View file

@ -13,8 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome, getHeaderFromHeaders */ /* import-globals-from pdfHandler.js */
/* exported saveReferer */
'use strict'; 'use strict';
/** /**

View file

@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* globals chrome */
'use strict'; 'use strict';

View file

@ -14,7 +14,6 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* eslint strict: ["error", "function"] */ /* eslint strict: ["error", "function"] */
/* globals chrome, crypto, Headers, Request */
(function() { (function() {
'use strict'; 'use strict';

View file

@ -8,7 +8,18 @@
"sourceType": "script" "sourceType": "script"
}, },
"plugins": [
"mozilla"
],
"globals": {
"Components": false,
"dump": false
},
"rules": { "rules": {
"mozilla/import-globals": "error",
// Best Practices // Best Practices
"consistent-return": "error", "consistent-return": "error",

View file

@ -12,8 +12,8 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, dump, XPCOMUtils, PdfStreamConverter, /* globals PdfStreamConverter, APP_SHUTDOWN, PdfjsChromeUtils,
APP_SHUTDOWN, PdfjsChromeUtils, PdfjsContentUtils */ PdfjsContentUtils */
"use strict"; "use strict";

View file

@ -12,8 +12,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, XPCOMUtils, PdfjsContentUtils, /* eslint-env mozilla/frame-script */
PdfjsContentUtils, PdfStreamConverter, addMessageListener */
"use strict"; "use strict";

View file

@ -12,8 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, XPCOMUtils, PdfjsChromeUtils,
PdfjsContentUtils, PdfStreamConverter */
"use strict"; "use strict";

View file

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services */
"use strict"; "use strict";

View file

@ -13,7 +13,6 @@
* limitations under the License. * limitations under the License.
*/ */
/* eslint max-len: ["error", 100] */ /* eslint max-len: ["error", 100] */
/* globals Components, Services */
"use strict"; "use strict";

View file

@ -12,8 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, XPCOMUtils, NetUtil, PrivateBrowsingUtils,
dump, NetworkManager, PdfJsTelemetry, PdfjsContentUtils */
"use strict"; "use strict";

View file

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, XPCOMUtils */
"use strict"; "use strict";

View file

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, Services, XPCOMUtils */
"use strict"; "use strict";

View file

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, PdfJs, Services */
"use strict"; "use strict";

View file

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals Components, PdfjsContentUtils */
"use strict"; "use strict";

View file

@ -9,6 +9,7 @@
"babel-preset-es2015": "^6.24.1", "babel-preset-es2015": "^6.24.1",
"escodegen": "^1.8.0", "escodegen": "^1.8.0",
"eslint": "^3.11.1", "eslint": "^3.11.1",
"eslint-plugin-mozilla": "^0.2.47",
"gulp": "^3.9.1", "gulp": "^3.9.1",
"gulp-rename": "^1.2.2", "gulp-rename": "^1.2.2",
"gulp-replace": "^0.5.4", "gulp-replace": "^0.5.4",