ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 17:30:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[api-minor] Remove the deprecated onUnsupportedFeature functionality (PR 15758 follow-up)

Browse source 
This was deprecated in PR 15758, which has now been included in three official PDF.js releases.
While PR 15880 did limit the bundle-size impact of this functionality on e.g. the Firefox PDF Viewer, it still leads to some unnecessary "bloat" that these changes remove.
Furthermore, with this being deprecated there'd also be no effort put into e.g. extending the `UNSUPPORTED_FEATURES` list when handling future error cases.
This commit is contained in:
Jonas Jenwald 2023-03-07 09:42:04 +01:00
parent e11371c75f
commit 2f3dcc2327
7 changed files with 5 additions and 201 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/core/document.js
View file

@ -27,7 +27,6 @@ import {
stringToPDFString,
stringToUTF8String,
unreachable,
UNSUPPORTED_FEATURES,
Util,
warn,
} from "../shared/util.js";
@ -220,15 +219,8 @@ class Page {
/**
* @private
*/
_onSubStreamError(handler, reason, objId) {
_onSubStreamError(reason, objId) {
if (this.evaluatorOptions.ignoreErrors) {
if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
// Error(s) when reading one of the /Contents sub-streams -- sending
// unsupported feature notification and allow parsing to continue.
handler.send("UnsupportedFeature", {
featureId: UNSUPPORTED_FEATURES.errorContentSubStream,
});
}
warn(`getContentStream - ignoring sub-stream (${objId}): "${reason}".`);
return;
}
@ -238,7 +230,7 @@ class Page {
/**
* @returns {Promise<BaseStream>}
*/
getContentStream(handler) {
getContentStream() {
return this.pdfManager.ensure(this, "content").then(content => {
if (content instanceof BaseStream) {
return content;
@ -246,7 +238,7 @@ class Page {
if (Array.isArray(content)) {
return new StreamsSequenceStream(
content,
this._onSubStreamError.bind(this, handler)
this._onSubStreamError.bind(this)
);
}
// Replace non-existent page content with empty content.
@ -378,7 +370,7 @@ class Page {
cacheKey,
annotationStorage = null,
}) {
const contentStreamPromise = this.getContentStream(handler);
const contentStreamPromise = this.getContentStream();
const resourcesPromise = this.loadResources([
"ColorSpace",
"ExtGState",
@ -528,7 +520,7 @@ class Page {
sink,
combineTextItems,
}) {
const contentStreamPromise = this.getContentStream(handler);
const contentStreamPromise = this.getContentStream();
const resourcesPromise = this.loadResources([
"ExtGState",
"Font",