ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-10 02:05:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use shorter local variable names in a few AppOptions methods

Browse source 
Besides being slightly shorter, this should help reduce the risk of confusion given the very similar global Object/Map names.
This commit is contained in:
Jonas Jenwald 2024-07-21 10:10:23 +02:00
parent ebb3d27125
commit 45ce3a057f
1 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

22
web/app_options.js
View file

@ -506,23 +506,23 @@ class AppOptions {
static getAll(kind = null, defaultOnly = false) { static getAll(kind = null, defaultOnly = false) {
const options = Object.create(null); const options = Object.create(null);
for (const name in defaultOptions) { for (const name in defaultOptions) {
const defaultOption = defaultOptions[name]; const defaultOpt = defaultOptions[name];
if (kind && !(kind & defaultOption.kind)) { if (kind && !(kind & defaultOpt.kind)) {
continue; continue;
} }
options[name] = options[name] =
!defaultOnly && userOptions.has(name) !defaultOnly && userOptions.has(name)
? userOptions.get(name) ? userOptions.get(name)
: defaultOption.value; : defaultOpt.value;
} }
return options; return options;
} }
static set(name, value) { static set(name, value) {
const defaultOption = defaultOptions[name]; const defaultOpt = defaultOptions[name];
if (!defaultOption || typeof value !== typeof defaultOption.value) { if (!defaultOpt || typeof value !== typeof defaultOpt.value) {
return; return;
} }
userOptions.set(name, value); userOptions.set(name, value);
@ -532,23 +532,23 @@ class AppOptions {
let events; let events;
for (const name in options) { for (const name in options) {
const defaultOption = defaultOptions[name], const defaultOpt = defaultOptions[name],
userOption = options[name]; userOpt = options[name];
if (!defaultOption || typeof userOption !== typeof defaultOption.value) { if (!defaultOpt || typeof userOpt !== typeof defaultOpt.value) {
continue; continue;
} }
if (prefs) { if (prefs) {
const { kind } = defaultOption; const { kind } = defaultOpt;
if (!(kind & OptionKind.BROWSER || kind & OptionKind.PREFERENCE)) { if (!(kind & OptionKind.BROWSER || kind & OptionKind.PREFERENCE)) {
continue; continue;
} }
if (this.eventBus && kind & OptionKind.EVENT_DISPATCH) { if (this.eventBus && kind & OptionKind.EVENT_DISPATCH) {
(events ||= new Map()).set(name, userOption); (events ||= new Map()).set(name, userOpt);
} }
} }
userOptions.set(name, userOption); userOptions.set(name, userOpt);
} }
if (events) { if (events) {