ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 01:10:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Editor] Take into account the page translation when computing the quadpoints when saving an highlight

Browse source 
It fixes #18360.
This commit is contained in:
Calixte Denizet 2024-07-01 23:59:37 +02:00
parent c280c520ee
commit 576aaf7cc1
4 changed files with 39 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

35
test/integration/highlight_editor_spec.mjs
View file

@ -1302,6 +1302,41 @@ describe("Highlight Editor", () => {
});
});
describe("Quadpoints must be correct when they're in a translated page", () => {
let pages;
beforeAll(async () => {
pages = await loadAndWait("issue18360.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages);
});
it("must check that the quadpoints for an highlight are almost correct", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await switchToHighlight(page);
const rect = await getSpanRectFromText(page, 1, "Hello World");
await page.mouse.click(
rect.x + rect.width / 4,
rect.y + rect.height / 2,
{ count: 2, delay: 100 }
);
await page.waitForSelector(getEditorSelector(0));
await waitForSerialized(page, 1);
const quadPoints = await getFirstSerialized(page, e => e.quadPoints);
const expected = [148, 624, 176, 624, 148, 637, 176, 637];
expect(quadPoints.every((x, i) => Math.abs(x - expected[i]) <= 5))
.withContext(`In ${browserName} (got ${quadPoints})`)
.toBeTrue();
})
);
});
});
describe("Editor must be unselected when the color picker is Escaped", () => {
let pages;