ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-09 17:55:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address the final round of review comments for Content-Disposition filename extraction

Browse source 
This patch updates the `IPDFStreamReader` interface and ensures that the interface/implementation of `network.js`, `fetch_stream.js`, `node_stream.js`, and `transport_stream.js` all match properly.
The unit-tests are also adjusted, to more closely replicate the actual behaviour of the various actual `IPDFStreamReader` implementations.
Finally, this patch adjusts the use of the Content-Disposition filename when setting the title in the viewer, and adds `PDFDocumentProperties` support as well.
This commit is contained in:
Jonas Jenwald 2018-01-16 16:24:36 +01:00
parent eb1f6f4c24
commit 69a8336cf1
12 changed files with 151 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/display/fetch_stream.js
View file

@ -67,9 +67,9 @@ class PDFFetchStream {
class PDFFetchStreamReader {
constructor(stream) {
this._stream = stream;
this._fileName = null;
this._reader = null;
this._loaded = 0;
this._filename = null;
let source = stream.source;
this._withCredentials = source.withCredentials;
this._contentLength = source.length;
@ -104,7 +104,6 @@ class PDFFetchStreamReader {
const getResponseHeader = (name) => {
return response.headers.get(name);
};
let { allowRangeRequests, suggestedLength, } =
validateRangeRequestCapabilities({
getResponseHeader,
@ -115,7 +114,8 @@ class PDFFetchStreamReader {
this._contentLength = suggestedLength;
this._isRangeSupported = allowRangeRequests;
this._fileName = extractFilenameFromHeader(getResponseHeader);
this._filename = extractFilenameFromHeader(getResponseHeader);
// We need to stop reading when range is supported and streaming is
// disabled.
@ -131,12 +131,12 @@ class PDFFetchStreamReader {
return this._headersCapability.promise;
}
get contentLength() {
return this._contentLength;
get filename() {
return this._filename;
}
get fileName() {
return this._fileName;
get contentLength() {
return this._contentLength;
}
get isRangeSupported() {