ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-10 02:05:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enable the unicorn/prefer-dom-node-append ESLint plugin rule

Browse source 
This rule will help enforce slightly shorter code, especially since you can insert multiple elements at once, and according to MDN `Element.append()` is available in all browsers that we currently support.

Please find additional information here:
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/append
 - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-append.md
This commit is contained in:
Jonas Jenwald 2022-06-12 12:20:25 +02:00
parent d7122becaf
commit 8129815538
39 changed files with 200 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/display/text_layer.js
View file

@ -658,7 +658,7 @@ class TextLayerRenderTask {
if (items[i].id !== null) {
this._container.setAttribute("id", `${items[i].id}`);
}
parent.appendChild(this._container);
parent.append(this._container);
} else if (items[i].type === "endMarkedContent") {
this._container = this._container.parentNode;
}
@ -710,12 +710,12 @@ class TextLayerRenderTask {
}
if (textDivProperties.hasText) {
this._container.appendChild(textDiv);
this._container.append(textDiv);
}
if (textDivProperties.hasEOL) {
const br = document.createElement("br");
br.setAttribute("role", "presentation");
this._container.appendChild(br);
this._container.append(br);
}
}