ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 17:30:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Editor] Avoid to use parent of editors in destroyed pages

Browse source
This commit is contained in:
Calixte Denizet 2023-09-07 12:30:29 +02:00
parent cf5a1d60a6
commit 8ab4e2e6e7
5 changed files with 106 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/display/editor/tools.js
View file

@ -1565,6 +1565,8 @@ class AnnotationEditorUIManager {
* Set up the drag session for moving the selected editors.
*/
setUpDragSession() {
// Note: don't use any references to the editor's parent which can be null
// if the editor belongs to a destroyed page.
if (!this.hasSelection) {
return;
}
@ -1575,7 +1577,7 @@ class AnnotationEditorUIManager {
this.#draggingEditors.set(editor, {
savedX: editor.x,
savedY: editor.y,
savedPageIndex: editor.parent.pageIndex,
savedPageIndex: editor.pageIndex,
newX: 0,
newY: 0,
newPageIndex: -1,
@ -1596,14 +1598,14 @@ class AnnotationEditorUIManager {
this.#draggingEditors = null;
let mustBeAddedInUndoStack = false;
for (const [{ x, y, parent }, value] of map) {
for (const [{ x, y, pageIndex }, value] of map) {
value.newX = x;
value.newY = y;
value.newPageIndex = parent.pageIndex;
value.newPageIndex = pageIndex;
mustBeAddedInUndoStack ||=
x !== value.savedX ||
y !== value.savedY ||
parent.pageIndex !== value.savedPageIndex;
pageIndex !== value.savedPageIndex;
}
if (!mustBeAddedInUndoStack) {