ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-10 10:15:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enable the ESLint prefer-const rule globally (PR 11450 follow-up)

Browse source 
Please find additional details about the ESLint rule at https://eslint.org/docs/rules/prefer-const

With the recent introduction of Prettier this sort of mass enabling of ESLint rules becomes a lot easier, since the code will be automatically reformatted as necessary to account for e.g. changed line lengths.

Note that this patch is generated automatically, by using the ESLint `--fix` argument, and will thus require some additional clean-up (which is done separately).
This commit is contained in:
Jonas Jenwald 2020-01-24 09:48:21 +01:00
parent d2d9441373
commit 9e262ae7fa
54 changed files with 676 additions and 661 deletions
Download patch file Download diff file Expand all files Collapse all files

45
test/unit/api_spec.js
View file

@ -50,9 +50,9 @@ import { isNodeJS } from "../../src/shared/is_node.js";
import { Metadata } from "../../src/display/metadata.js";
describe("api", function() {
let basicApiFileName = "basicapi.pdf";
let basicApiFileLength = 105779; // bytes
let basicApiGetDocumentParams = buildGetDocumentParams(basicApiFileName);
const basicApiFileName = "basicapi.pdf";
const basicApiFileLength = 105779; // bytes
const basicApiGetDocumentParams = buildGetDocumentParams(basicApiFileName);
let CanvasFactory;
@ -102,7 +102,7 @@ describe("api", function() {
});
it("creates pdf doc from URL and aborts before worker initialized", function(done) {
var loadingTask = getDocument(basicApiGetDocumentParams);
let destroyed = loadingTask.destroy();
const destroyed = loadingTask.destroy();
loadingTask.promise
.then(function(reason) {
@ -473,7 +473,7 @@ describe("api", function() {
pending("Worker is not supported in Node.js.");
}
let workerSrc = PDFWorker.getWorkerSrc();
const workerSrc = PDFWorker.getWorkerSrc();
expect(typeof workerSrc).toEqual("string");
expect(workerSrc).toEqual(GlobalWorkerOptions.workerSrc);
});
@ -1339,8 +1339,8 @@ describe("api", function() {
it('gets viewport respecting "dontFlip" argument', function() {
const scale = 1,
rotation = 0;
let viewport = page.getViewport({ scale, rotation });
let dontFlipViewport = page.getViewport({
const viewport = page.getViewport({ scale, rotation });
const dontFlipViewport = page.getViewport({
scale,
rotation,
dontFlip: true,
@ -1511,15 +1511,15 @@ describe("api", function() {
});
it("gets operatorList with JPEG image (issue 4888)", function(done) {
let loadingTask = getDocument(buildGetDocumentParams("cmykjpeg.pdf"));
const loadingTask = getDocument(buildGetDocumentParams("cmykjpeg.pdf"));
loadingTask.promise
.then(pdfDoc => {
pdfDoc.getPage(1).then(pdfPage => {
pdfPage.getOperatorList().then(opList => {
let imgIndex = opList.fnArray.indexOf(OPS.paintImageXObject);
let imgArgs = opList.argsArray[imgIndex];
let { data } = pdfPage.objs.get(imgArgs[0]);
const imgIndex = opList.fnArray.indexOf(OPS.paintImageXObject);
const imgArgs = opList.argsArray[imgIndex];
const { data } = pdfPage.objs.get(imgArgs[0]);
expect(data instanceof Uint8ClampedArray).toEqual(true);
expect(data.length).toEqual(90000);
@ -1607,7 +1607,7 @@ describe("api", function() {
}, done.fail);
});
it("gets page stats after parsing page, with `pdfBug` set", function(done) {
let loadingTask = getDocument(
const loadingTask = getDocument(
buildGetDocumentParams(basicApiFileName, { pdfBug: true })
);
@ -1623,7 +1623,7 @@ describe("api", function() {
expect(stats instanceof StatTimer).toEqual(true);
expect(stats.times.length).toEqual(1);
let [statEntry] = stats.times;
const [statEntry] = stats.times;
expect(statEntry.name).toEqual("Page Request");
expect(statEntry.end - statEntry.start).toBeGreaterThanOrEqual(0);
@ -1631,7 +1631,7 @@ describe("api", function() {
}, done.fail);
});
it("gets page stats after rendering page, with `pdfBug` set", function(done) {
let loadingTask = getDocument(
const loadingTask = getDocument(
buildGetDocumentParams(basicApiFileName, { pdfBug: true })
);
let canvasAndCtx;
@ -1639,13 +1639,13 @@ describe("api", function() {
loadingTask.promise
.then(pdfDoc => {
return pdfDoc.getPage(1).then(pdfPage => {
let viewport = pdfPage.getViewport({ scale: 1 });
const viewport = pdfPage.getViewport({ scale: 1 });
canvasAndCtx = CanvasFactory.create(
viewport.width,
viewport.height
);
let renderTask = pdfPage.render({
const renderTask = pdfPage.render({
canvasContext: canvasAndCtx.context,
canvasFactory: CanvasFactory,
viewport,
@ -1659,7 +1659,7 @@ describe("api", function() {
expect(stats instanceof StatTimer).toEqual(true);
expect(stats.times.length).toEqual(3);
let [statEntryOne, statEntryTwo, statEntryThree] = stats.times;
const [statEntryOne, statEntryTwo, statEntryThree] = stats.times;
expect(statEntryOne.name).toEqual("Page Request");
expect(statEntryOne.end - statEntryOne.start).toBeGreaterThanOrEqual(
0
@ -1700,10 +1700,13 @@ describe("api", function() {
});
it("re-render page, using the same canvas, after cancelling rendering", function(done) {
let viewport = page.getViewport({ scale: 1 });
let canvasAndCtx = CanvasFactory.create(viewport.width, viewport.height);
const viewport = page.getViewport({ scale: 1 });
const canvasAndCtx = CanvasFactory.create(
viewport.width,
viewport.height
);
let renderTask = page.render({
const renderTask = page.render({
canvasContext: canvasAndCtx.context,
canvasFactory: CanvasFactory,
viewport,
@ -1720,7 +1723,7 @@ describe("api", function() {
}
)
.then(() => {
let reRenderTask = page.render({
const reRenderTask = page.render({
canvasContext: canvasAndCtx.context,
canvasFactory: CanvasFactory,
viewport,