ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-09 01:35:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename BaseViewer._setDocumentViewerElement to BaseViewer._viewerElement

Browse source 
It was pointed out the the old name felt confusing, so let's just rename the getter since it's an internal property anyway.
This commit is contained in:
Jonas Jenwald 2020-03-24 14:12:10 +01:00
parent c5b0b5c754
commit a24ad28d75
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
web/base_viewer.js
View file

@ -391,9 +391,9 @@ class BaseViewer {
/**
* @private
*/
get _setDocumentViewerElement() {
get _viewerElement() {
// In most viewers, e.g. `PDFViewer`, this should return `this.viewer`.
throw new Error("Not implemented: _setDocumentViewerElement");
throw new Error("Not implemented: _viewerElement");
}
/**
@ -479,7 +479,7 @@ class BaseViewer {
for (let pageNum = 1; pageNum <= pagesCount; ++pageNum) {
const pageView = new PDFPageView({
container: this._setDocumentViewerElement,
container: this._viewerElement,
eventBus: this.eventBus,
id: pageNum,
scale,