ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-08 17:30:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename BaseViewer._setDocumentViewerElement to BaseViewer._viewerElement

Browse source 
It was pointed out the the old name felt confusing, so let's just rename the getter since it's an internal property anyway.
This commit is contained in:
Jonas Jenwald 2020-03-24 14:12:10 +01:00
parent c5b0b5c754
commit a24ad28d75
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
web/base_viewer.js
View file

@ -391,9 +391,9 @@ class BaseViewer {
/** /**
* @private * @private
*/ */
get _setDocumentViewerElement() { get _viewerElement() {
// In most viewers, e.g. `PDFViewer`, this should return `this.viewer`. // In most viewers, e.g. `PDFViewer`, this should return `this.viewer`.
throw new Error("Not implemented: _setDocumentViewerElement"); throw new Error("Not implemented: _viewerElement");
} }
/** /**
@ -479,7 +479,7 @@ class BaseViewer {
for (let pageNum = 1; pageNum <= pagesCount; ++pageNum) { for (let pageNum = 1; pageNum <= pagesCount; ++pageNum) {
const pageView = new PDFPageView({ const pageView = new PDFPageView({
container: this._setDocumentViewerElement, container: this._viewerElement,
eventBus: this.eventBus, eventBus: this.eventBus,
id: pageNum, id: pageNum,
scale, scale,

4
web/pdf_single_page_viewer.js
View file

@ -27,12 +27,12 @@ class PDFSinglePageViewer extends BaseViewer {
}); });
} }
get _setDocumentViewerElement() { get _viewerElement() {
// Since we only want to display *one* page at a time when using the // Since we only want to display *one* page at a time when using the
// `PDFSinglePageViewer`, we cannot append them to the `viewer` DOM element. // `PDFSinglePageViewer`, we cannot append them to the `viewer` DOM element.
// Instead, they are placed in a `DocumentFragment`, and only the current // Instead, they are placed in a `DocumentFragment`, and only the current
// page is displayed in the viewer (refer to `this._ensurePageViewVisible`). // page is displayed in the viewer (refer to `this._ensurePageViewVisible`).
return shadow(this, "_setDocumentViewerElement", this._shadowViewer); return shadow(this, "_viewerElement", this._shadowViewer);
} }
_resetView() { _resetView() {

4
web/pdf_viewer.js
View file

@ -17,8 +17,8 @@ import { BaseViewer } from "./base_viewer.js";
import { shadow } from "pdfjs-lib"; import { shadow } from "pdfjs-lib";
class PDFViewer extends BaseViewer { class PDFViewer extends BaseViewer {
get _setDocumentViewerElement() { get _viewerElement() {
return shadow(this, "_setDocumentViewerElement", this.viewer); return shadow(this, "_viewerElement", this.viewer);
} }
_scrollIntoView({ pageDiv, pageSpot = null, pageNumber = null }) { _scrollIntoView({ pageDiv, pageSpot = null, pageNumber = null }) {