ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-07 17:05:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #18650 from calixteman/bug1914480

Browse source 
[Editor] Add a missing parameter in the telemetry for the new alt text flow (bug 1914480)
This commit is contained in:
calixteman 2024-08-26 15:33:41 +02:00 • committed by GitHub
commit b58c24ab09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/display/editor/stamp.js
View file

@ -159,7 +159,7 @@ class StampEditor extends AnnotationEditor {
) { ) {
this._reportTelemetry({ this._reportTelemetry({
action: "pdfjs.image.image_added", action: "pdfjs.image.image_added",
data: { alt_text_modal: false }, data: { alt_text_modal: false, alt_text_type: "empty" },
}); });
try { try {
// The alt-text dialog isn't opened but we still want to guess the alt // The alt-text dialog isn't opened but we still want to guess the alt

7
web/new_alt_text_manager.js
View file

@ -416,7 +416,7 @@ class NewAltTextManager {
}); });
this.#currentEditor._reportTelemetry({ this.#currentEditor._reportTelemetry({
action: "pdfjs.image.image_added", action: "pdfjs.image.image_added",
data: { alt_text_modal: false }, data: { alt_text_modal: true, alt_text_type: "skipped" },
}); });
this.#finish(); this.#finish();
} }
@ -464,7 +464,10 @@ class NewAltTextManager {
} }
this.#currentEditor._reportTelemetry({ this.#currentEditor._reportTelemetry({
action: "pdfjs.image.image_added", action: "pdfjs.image.image_added",
data: { alt_text_modal: true }, data: {
alt_text_modal: true,
alt_text_type: altText ? "present" : "empty",
},
}); });
this.#currentEditor._reportTelemetry({ this.#currentEditor._reportTelemetry({