Use native Math functions in the custom log2 function

It is quite confusing that the custom function is called `log2` while it
actually returns the ceiling value and handles zero and negative values
differently than the native function.

To resolve this, we add a comment that explains these differences and
make the function use the native `Math` functions internally instead of
using our own custom logic. To verify that the function does what we
expect, we add unit tests.

All browsers except for IE support `Math.log2` for quite a long time
already (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/log2).
For IE, we use the core-js polyfill.

According to the microbenchmark at https://jsperf.com/log2-pdfjs/1,
using the native functions should also be faster, in my testing almost
six times as fast.
This commit is contained in:
Tim van der Meij 2017-12-09 17:24:31 +01:00
parent 371ca51402
commit c35bbd11b0
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
3 changed files with 29 additions and 6 deletions

View file

@ -348,6 +348,14 @@ PDFJS.compatibilityChecked = true;
Array.prototype.includes = require('core-js/fn/array/includes');
})();
// Provides support for Math.log2 in legacy browsers.
// Support: IE.
(function checkMathLog2() {
if (Math.log2) {
return;
}
Math.log2 = require('core-js/fn/math/log2');
})();
// Provides support for Number.isNaN in legacy browsers.
// Support: IE.