Attempt to simplify the fileattachmentannotation event dispatching

This attempts to reduced the level of indirection, and the amount of code, when dispatching `fileattachmentannotation` events, by removing the `PDFLinkService.onFileAttachmentAnnotation` method and just accessing `PDFLinkService.eventBus` directly in the `FileAttachmentAnnotationElement` constructor.
Given that other properties, such as `externalLinkTarget`/`externalLinkRel`, are already being accessed directly this pattern seems fine here as well.
This commit is contained in:
Jonas Jenwald 2018-10-01 11:55:25 +02:00
parent ec10cae5b6
commit d60ce998f1
3 changed files with 11 additions and 30 deletions

View file

@ -67,11 +67,6 @@ class IPDFLinkService {
*/
executeNamedAction(action) {}
/**
* @param {Object} params
*/
onFileAttachmentAnnotation({ id, filename, content, }) {}
/**
* @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page.