ZenBrowserMirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/zen-browser/pdf.js.git synced 2025-07-07 17:05:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Editor] Define the "pdfjs-editor-new-alt-text-generated-alt-text-with-disclaimer" string once

Browse source 
This l10n-string is being re-defined once for every editor, i.e. currently four times, which seems unnecessary.
To avoid having to check if this l10n-string exists first, we can utilize rest parameters to move it into the `AnnotationEditor._l10nPromise` Map-definition instead.
This commit is contained in:
Jonas Jenwald 2024-08-27 09:58:38 +02:00
parent e9a319be2c
commit d70f5a1952
1 changed files with 8 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/display/editor/editor.js
View file

@ -219,27 +219,20 @@ class AnnotationEditor {
middleLeft: "pdfjs-editor-resizer-middle-left", middleLeft: "pdfjs-editor-resizer-middle-left",
}); });
AnnotationEditor._l10nPromise ||= new Map( AnnotationEditor._l10nPromise ||= new Map([
[ ...[
"pdfjs-editor-alt-text-button-label", "pdfjs-editor-alt-text-button-label",
"pdfjs-editor-alt-text-edit-button-label", "pdfjs-editor-alt-text-edit-button-label",
"pdfjs-editor-alt-text-decorative-tooltip", "pdfjs-editor-alt-text-decorative-tooltip",
"pdfjs-editor-new-alt-text-added-button-label", "pdfjs-editor-new-alt-text-added-button-label",
"pdfjs-editor-new-alt-text-missing-button-label", "pdfjs-editor-new-alt-text-missing-button-label",
"pdfjs-editor-new-alt-text-to-review-button-label", "pdfjs-editor-new-alt-text-to-review-button-label",
].map(str => [str, l10n.get(str)]) ].map(str => [str, l10n.get(str)]),
); ...[
// Strings that need l10n-arguments.
// The string isn't in the above list because the string has a parameter "pdfjs-editor-new-alt-text-generated-alt-text-with-disclaimer",
// (i.e. the guessed text) and we must pass it to the l10n function to get ].map(str => [str, l10n.get.bind(l10n, str)]),
// the correct translation. ]);
AnnotationEditor._l10nPromise.set(
"pdfjs-editor-new-alt-text-generated-alt-text-with-disclaimer",
l10n.get.bind(
l10n,
"pdfjs-editor-new-alt-text-generated-alt-text-with-disclaimer"
)
);
if (options?.strings) { if (options?.strings) {
for (const str of options.strings) { for (const str of options.strings) {