Fix inconsistent spacing and trailing commas in objects in test/ files, so we can enable the comma-dangle and object-curly-spacing ESLint rules later on

http://eslint.org/docs/rules/comma-dangle
http://eslint.org/docs/rules/object-curly-spacing

Given that we currently have quite inconsistent object formatting, fixing this in *one* big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead.

Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch.

```diff
diff --git a/test/chromium/test-telemetry.js b/test/chromium/test-telemetry.js
index cc412a31..2e5bdfa1 100755
--- a/test/chromium/test-telemetry.js
+++ b/test/chromium/test-telemetry.js
@@ -324,7 +324,7 @@ var tests = [
     var window = createExtensionGlobal();
     telemetryScript.runInNewContext(window);
     window.chrome.runtime.getManifest = function() {
-     return { version: '1.0.1', };
+      return { version: '1.0.1', };
     };
     window.Date.test_now_value += 12 * 36E5;
     telemetryScript.runInNewContext(window);
diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js
index 1f00747a..f22988e7 100644
--- a/test/unit/api_spec.js
+++ b/test/unit/api_spec.js
@@ -503,8 +503,9 @@ describe('api', function() {
     it('gets destinations, from /Dests dictionary', function(done) {
       var promise = doc.getDestinations();
       promise.then(function(data) {
-        expect(data).toEqual({ chapter1: [{ gen: 0, num: 17, }, { name: 'XYZ', },
-                                          0, 841.89, null], });
+        expect(data).toEqual({
+          chapter1: [{ gen: 0, num: 17, }, { name: 'XYZ', }, 0, 841.89, null],
+        });
         done();
       }).catch(function (reason) {
         done.fail(reason);
diff --git a/test/unit/function_spec.js b/test/unit/function_spec.js
index 66441212..62127eb9 100644
--- a/test/unit/function_spec.js
+++ b/test/unit/function_spec.js
@@ -492,9 +492,11 @@ describe('function', function() {
     it('check compiled mul', function() {
       check([0.25, 0.5, 'mul'], [], [0, 1], [{ input: [], output: [0.125], }]);
       check([0, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0], }]);
-      check([0.5, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0.125], }]);
+      check([0.5, 'mul'], [0, 1], [0, 1],
+            [{ input: [0.25], output: [0.125], }]);
       check([1, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0.25], }]);
-      check([0, 'exch', 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0], }]);
+      check([0, 'exch', 'mul'], [0, 1], [0, 1],
+            [{ input: [0.25], output: [0], }]);
       check([0.5, 'exch', 'mul'], [0, 1], [0, 1],
             [{ input: [0.25], output: [0.125], }]);
       check([1, 'exch', 'mul'], [0, 1], [0, 1],
```
This commit is contained in:
Jonas Jenwald 2017-06-02 12:55:01 +02:00
parent 593dec1bb7
commit efbd68efef
19 changed files with 111 additions and 108 deletions

View file

@ -480,7 +480,7 @@ describe('api', function() {
});
it('gets page index', function(done) {
// reference to second page
var ref = {num: 17, gen: 0};
var ref = { num: 17, gen: 0, };
var promise = doc.getPageIndex(ref);
promise.then(function(pageIndex) {
expect(pageIndex).toEqual(1);
@ -490,7 +490,7 @@ describe('api', function() {
});
});
it('gets invalid page index', function (done) {
var ref = { num: 3, gen: 0 }; // Reference to a font dictionary.
var ref = { num: 3, gen: 0, }; // Reference to a font dictionary.
var promise = doc.getPageIndex(ref);
promise.then(function () {
done.fail('shall fail for invalid page reference.');
@ -503,8 +503,9 @@ describe('api', function() {
it('gets destinations, from /Dests dictionary', function(done) {
var promise = doc.getDestinations();
promise.then(function(data) {
expect(data).toEqual({ chapter1: [{ gen: 0, num: 17 }, { name: 'XYZ' },
0, 841.89, null] });
expect(data).toEqual({
chapter1: [{ gen: 0, num: 17, }, { name: 'XYZ', }, 0, 841.89, null],
});
done();
}).catch(function (reason) {
done.fail(reason);
@ -513,7 +514,7 @@ describe('api', function() {
it('gets a destination, from /Dests dictionary', function(done) {
var promise = doc.getDestination('chapter1');
promise.then(function(data) {
expect(data).toEqual([{ gen: 0, num: 17 }, { name: 'XYZ' },
expect(data).toEqual([{ gen: 0, num: 17, }, { name: 'XYZ', },
0, 841.89, null]);
done();
}).catch(function (reason) {
@ -538,8 +539,8 @@ describe('api', function() {
});
promise.then(function (destinations) {
expect(destinations).toEqual({
'Page.1': [{ num: 1, gen: 0}, { name: 'XYZ' }, 0, 375, null],
'Page.2': [{ num: 6, gen: 0}, { name: 'XYZ' }, 0, 375, null],
'Page.1': [{ num: 1, gen: 0, }, { name: 'XYZ', }, 0, 375, null],
'Page.2': [{ num: 6, gen: 0, }, { name: 'XYZ', }, 0, 375, null],
});
loadingTask.destroy().then(done);
@ -553,7 +554,7 @@ describe('api', function() {
return pdfDocument.getDestination('Page.1');
});
promise.then(function (destination) {
expect(destination).toEqual([{ num: 1, gen: 0}, { name: 'XYZ' },
expect(destination).toEqual([{ num: 1, gen: 0, }, { name: 'XYZ', },
0, 375, null]);
loadingTask.destroy().then(done);
@ -793,7 +794,7 @@ describe('api', function() {
it('gets download info', function(done) {
var promise = doc.getDownloadInfo();
promise.then(function (data) {
expect(data).toEqual({ length: basicApiFileLength });
expect(data).toEqual({ length: basicApiFileLength, });
done();
}).catch(function (reason) {
done.fail(reason);
@ -802,7 +803,7 @@ describe('api', function() {
it('gets stats', function(done) {
var promise = doc.getStats();
promise.then(function (stats) {
expect(stats).toEqual({ streamTypes: [], fontTypes: [] });
expect(stats).toEqual({ streamTypes: [], fontTypes: [], });
done();
}).catch(function (reason) {
done.fail(reason);
@ -864,7 +865,7 @@ describe('api', function() {
expect(page.rotate).toEqual(0);
});
it('gets ref', function () {
expect(page.ref).toEqual({ num: 15, gen: 0 });
expect(page.ref).toEqual({ num: 15, gen: 0, });
});
it('gets userUnit', function () {
expect(page.userUnit).toEqual(1.0);
@ -886,12 +887,12 @@ describe('api', function() {
expect(data.length).toEqual(4);
});
var displayPromise = page.getAnnotations({ intent: 'display' }).then(
var displayPromise = page.getAnnotations({ intent: 'display', }).then(
function (data) {
expect(data.length).toEqual(4);
});
var printPromise = page.getAnnotations({ intent: 'print' }).then(
var printPromise = page.getAnnotations({ intent: 'print', }).then(
function (data) {
expect(data.length).toEqual(4);
});
@ -1011,7 +1012,7 @@ describe('api', function() {
promise.then(function (stats) {
expect(stats).toEqual({ streamTypes: expectedStreamTypes,
fontTypes: expectedFontTypes });
fontTypes: expectedFontTypes, });
done();
}).catch(function (reason) {
done.fail(reason);