mirror of
https://github.com/zen-browser/pdf.js.git
synced 2025-07-08 01:10:08 +02:00
Remove the PDFSinglePageViewer
-specific code from web/secondary_toolbar.js
(PR 9877 follow-up)
This was added on the assumption that the viewer would (eventually) start using the `PDFSinglePageViewer` for e.g. PAGE-scrolling mode and PresentationMode. However, having both a `PDFViewer` and a `PDFSinglePageViewer` side-by-side in the viewer would've been tricky to implement well, which is why PR 14112 implemented PAGE-scrolling for the general `BaseViewer` instead. Given that the default viewer is no longer (potentially) going to use `PDFSinglePageViewer`, there's code in the `SecondaryToolbar` (and related CSS rules) which is now unnecessary.
This commit is contained in:
parent
700eaecddd
commit
f15eb63ed5
3 changed files with 9 additions and 31 deletions
|
@ -15,7 +15,6 @@
|
|||
|
||||
import { SCROLLBAR_PADDING, ScrollMode, SpreadMode } from "./ui_utils.js";
|
||||
import { CursorTool } from "./pdf_cursor_tools.js";
|
||||
import { PDFSinglePageViewer } from "./pdf_viewer.js";
|
||||
|
||||
/**
|
||||
* @typedef {Object} SecondaryToolbarOptions
|
||||
|
@ -166,22 +165,6 @@ class SecondaryToolbar {
|
|||
|
||||
// Bind the event listener for adjusting the 'max-height' of the toolbar.
|
||||
this.eventBus._on("resize", this._setMaxHeight.bind(this));
|
||||
|
||||
// Hide the Scroll/Spread mode buttons, when they're not applicable to the
|
||||
// current `BaseViewer` instance (in particular `PDFSinglePageViewer`).
|
||||
this.eventBus._on("baseviewerinit", evt => {
|
||||
if (evt.source instanceof PDFSinglePageViewer) {
|
||||
this.toolbarButtonContainer.classList.add(
|
||||
"hiddenScrollModeButtons",
|
||||
"hiddenSpreadModeButtons"
|
||||
);
|
||||
} else {
|
||||
this.toolbarButtonContainer.classList.remove(
|
||||
"hiddenScrollModeButtons",
|
||||
"hiddenSpreadModeButtons"
|
||||
);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue