Calixte Denizet
576aaf7cc1
[Editor] Take into account the page translation when computing the quadpoints when saving an highlight
...
It fixes #18360 .
2024-07-02 10:12:26 +02:00
Calixte Denizet
390afcb685
[Editor] Remove the various listeners when destroying the editor manager
2024-06-19 10:33:52 +02:00
Calixte Denizet
6fa98ac99f
[api-minor] Simplify how the list of points are structured
...
Instead of sending to the main thread an array of Objects for a list of points (or quadpoints),
we'll send just a basic float buffer.
It should slightly improve performances (especially when cloning the data) and use slightly less memory.
2024-05-30 15:36:15 +02:00
Calixte Denizet
54110de109
[Editor] Remove the mark from the highlight element and set its role to mark (bug 1889623)
...
Set aria-label to the highlighted text, this way the focus frame is exactly set
on the highlight element and the higlighted text is read.
2024-04-04 18:06:05 +02:00
Calixte Denizet
d5a0e557c2
[Editor] Fix undoing an editor deletion (bug 1886959)
...
The original bug was because the parent was null when trying to show
an highlight annotation which led to an exception.
That led me to think about having some null/non-null parent when removing
an editor: it's a mess especially if a destroyed parent is still attached
to an editor. Consequently, this patch always sets the parent to null when
deleting the editor.
2024-03-25 14:17:40 +01:00
Calixte Denizet
f676c2c0c8
[Editor] Improve the accessibility of the highlight editor (bug 1881743)
2024-03-11 14:21:43 +01:00
Calixte Denizet
39aeea3e94
[Editor] Add a toggle button to show/hide all the highlights (bug 1867740)
2024-03-07 13:16:59 +01:00
Calixte Denizet
bd5875d066
[Editor] Let a free highlight be clipped when its bounding box exceeds the page limits (bug 1883632)
2024-03-05 16:47:07 +01:00
Calixte Denizet
ecb4262b13
[Editor] Set the creation method for free highlights to 'main_toolbar' (bug 1883394)
2024-03-04 16:58:50 +01:00
Calixte Denizet
30101cbb31
[Editor] Fix the quadpoints value when serializing an highlight annotation
...
The coordinates of each point in a box are in the page coordinates system.
2024-03-01 11:36:16 +01:00
Calixte Denizet
a9f47e87d5
[Editor] Add the possibility to move the caret with the keyboard once an highlight has been made (bug 1881684)
2024-02-29 18:18:13 +01:00
Jonas Jenwald
a92b38e71c
Inline the HighlightEditor.#telemetryType getter at its only call-site (PR 17748 follow-up)
2024-02-28 20:47:01 +01:00
Calixte Denizet
3a7e638fce
[Editor] Count the colors used when highlighting whatever the highlight kind is
2024-02-28 18:24:24 +01:00
Calixte Denizet
65342d2bee
[Editor] Add some telemetry for the highlight feature (bug 1866437)
2024-02-28 10:17:11 +01:00
Calixte Denizet
de1985abbb
[Editor] Set rotated free highlight at the right position after having changed its thickness (bug 1879108)
2024-02-11 21:06:56 +01:00
Calixte Denizet
b5e446213e
[Editor] Disable the thickness slider for non-free highlight
2024-02-09 22:54:53 +01:00
Calixte Denizet
8d61fc1fde
[Editor] Compute the position of the last point before applying rotation (bug 1879113)
2024-02-08 21:08:24 +01:00
Calixte Denizet
7529c1e3dc
[Editor] Fix the position of the free highlight toolbar
2024-01-30 15:40:33 +01:00
Calixte Denizet
2b8ecf5688
[Editor] Add the possibility to change the thickness of a free highlight (bug 1876096)
2024-01-24 22:04:39 +01:00
Calixte Denizet
d713df28c3
[Editor] Update the parameters in the UI of the last selected editor when undoing/redoing
2024-01-24 18:16:51 +01:00
Calixte Denizet
d64f334f98
[Editor] Add support for printing/saving free highlight annotations
2024-01-19 12:58:46 +01:00
Calixte Denizet
8fbfef0c07
[Editor] Add the ability to make a free highlight (i.e. without having to select some text) (bug 1856218)
...
The free highlighting is enabled when the mouse pointer isn't on some text.
Then we draw a shape with smoothed borders corresponding to the movement of
the mouse.
Printing/saving and changing the thickness will come later.
2024-01-18 16:26:04 +01:00
Calixte Denizet
70a9d8f3bc
[Editor] Avoid to move a non-draggable editor with the keyboard
2024-01-16 21:41:52 +01:00
Calixte Denizet
ee72b32dc2
[Editor] Slightly simplify the serialization of an highlight annotation
...
We were computing width and height of the annotation before serializing
which is useless because the rect already contains this information.
2024-01-15 18:22:01 +01:00
Calixte Denizet
fc7c320bd8
[Editor] Correctly serialize highlight data (regression from #17499 )
2024-01-12 15:37:01 +01:00
Calixte Denizet
b4a7007397
[Editor] Don't throw when changing the color of an invisible highlight
2024-01-11 17:48:06 +01:00
Calixte Denizet
17e1519410
[Editor] Init the default highlight color before creating the first editor instance
...
We want to be able to draw an highlight with the default color but without having an
instance of the HighlightEditor.
2024-01-05 17:52:54 +01:00
Calixte Denizet
35863cd54b
[Editor] Take into account the crop box when saving/printing some highlighted text (bug 1872721)
2024-01-02 18:53:33 +01:00
calixteman
8702e1bbb2
Merge pull request #17359 from calixteman/editor_highlight_color_picker
...
[Editor] Add a color picker with predefined colors for highlighting text (bug 1866434)
2023-12-06 11:06:55 +01:00
Calixte Denizet
ff23d37fa2
[Editor] Add a color picker with predefined colors for highlighting text (bug 1866434)
...
The doorhanger for highlighting has a basic color picker composed of 5 predefined colors
to set the default color to use.
These colors can be changed thanks to a preference for now but it's something which could
be changed in the Firefox settings in the future.
Each highlight has in its own toolbar a color picker to just change its color.
The different color pickers are so similar (modulo few differences in their styles) that
this patch introduces a new class ColorPicker which provides a color picker component
which could be reused in future editors.
All in all, a large part of this patch is dedicated to color picker itself and its style
and the rest is almost a matter of wiring the component.
2023-12-05 23:27:22 +01:00
Calixte Denizet
621b7af60d
[Editor] Highlight must keep selected after the document has been scrolled
2023-12-05 23:22:35 +01:00
Calixte Denizet
83d0b6cb55
[Editor] Disable mouse events when leaving the highlight mode
2023-12-01 17:10:19 +01:00
Calixte Denizet
1ea6293923
[Editor] Add a new editor to highlight some text in a pdf (bug 1866119)
...
This patch is first big step for the new highlight feature.
Few patches will follow in order to conform to the specs UX/UI gave us.
2023-11-28 14:21:53 +01:00
