🐛 Ask user for binary name as part of the setup process

This commit is contained in:
trickypr 2022-07-14 11:53:00 +10:00
parent 14912e1f4b
commit 075fa66e9a
2 changed files with 14 additions and 1 deletions

View file

@ -62,6 +62,12 @@ Next it will ask for the name of your browser. Avoid references to Firefox or ot
? Enter a product name Gluon Example Browser ? Enter a product name Gluon Example Browser
``` ```
The binary name is the name that your program will be run from. We recommend that you add `-browser` to the end to [avoid conflicts with common utilities](https://github.com/dothq/browser/issues/604).
```
? Enter the name of the binary gluon-example-browser
```
Vendor is the company (or solo developer) who is creating the browser. Vendor is the company (or solo developer) who is creating the browser.
``` ```

View file

@ -82,7 +82,7 @@ export async function setupProject(): Promise<void> {
const productVersion = await getLatestFF(product) const productVersion = await getLatestFF(product)
const { version, name, appId, vendor, ui } = await prompts([ const { version, name, appId, vendor, ui, binaryName } = await prompts([
{ {
type: 'text', type: 'text',
name: 'version', name: 'version',
@ -95,6 +95,12 @@ export async function setupProject(): Promise<void> {
message: 'Enter a product name', message: 'Enter a product name',
initial: 'Example browser', initial: 'Example browser',
}, },
{
type: 'text',
name: 'binaryName',
message: 'Enter the name of the binary',
initial: 'example-browser',
},
{ {
type: 'text', type: 'text',
name: 'vendor', name: 'vendor',
@ -134,6 +140,7 @@ export async function setupProject(): Promise<void> {
name, name,
vendor, vendor,
appId, appId,
binaryName,
version: { product, version }, version: { product, version },
buildOptions: { buildOptions: {
generateBranding: false, generateBranding: false,