From 2123d285044a1fac94a8dcacb0e8ca3509eb3ca7 Mon Sep 17 00:00:00 2001
From: taroj1205 <taroj1205@gmail.com>
Date: Sun, 22 Jun 2025 20:01:23 +1200
Subject: [PATCH] chore(turbo): add build dependency to e2e test tasks in
 turbo.json for improved execution order

---
 .github/workflows/ci-pipeline.yml | 13 -------------
 turbo.json                        |  5 +++++
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/ci-pipeline.yml b/.github/workflows/ci-pipeline.yml
index 2f1b260..28d5b01 100644
--- a/.github/workflows/ci-pipeline.yml
+++ b/.github/workflows/ci-pipeline.yml
@@ -171,13 +171,6 @@ jobs:
       - name: Build project
         run: pnpm exec turbo run build
 
-      - name: Upload build artifacts
-        uses: actions/upload-artifact@v4
-        with:
-          name: dist
-          path: dist/
-          retention-days: 1
-
   playwright:
     name: Playwright Tests
     needs: [check_changes, setup, build]
@@ -186,12 +179,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Download build artifacts
-        uses: actions/download-artifact@v4
-        with:
-          name: dist
-          path: dist/
-
       - name: Restore Turborepo Cache
         uses: actions/cache@v4
         with:
diff --git a/turbo.json b/turbo.json
index 30d7815..2d4a634 100644
--- a/turbo.json
+++ b/turbo.json
@@ -33,26 +33,31 @@
     },
     "test:e2e": {
       "cache": true,
+      "dependsOn": ["build"],
       "inputs": ["src/**/*"],
       "outputs": ["playwright-report/**", "test-results/**"]
     },
     "test:e2e:shard1": {
       "cache": true,
+      "dependsOn": ["build"],
       "inputs": ["src/**/*"],
       "outputs": ["playwright-report/**", "test-results/**"]
     },
     "test:e2e:shard2": {
       "cache": true,
+      "dependsOn": ["build"],
       "inputs": ["src/**/*"],
       "outputs": ["playwright-report/**", "test-results/**"]
     },
     "test:e2e:shard3": {
       "cache": true,
+      "dependsOn": ["build"],
       "inputs": ["src/**/*"],
       "outputs": ["playwright-report/**", "test-results/**"]
     },
     "test:e2e:shard4": {
       "cache": true,
+      "dependsOn": ["build"],
       "inputs": ["src/**/*"],
       "outputs": ["playwright-report/**", "test-results/**"]
     },