test: Added some tests, b=(no-bug), c=tests, workspaces

.gitattributes

@@ -1,2 +1,4 @@
 *.patch linguist-language=C++
 *.d.ts linguist-language=TypeScript
+
+src/zen/tests/*.js linguist-language=Test

src/testing/mochitest/browser-test-js.patch

@@ -1,7 +1,21 @@
 diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js
-index ef29179988bb37e7ea441aa051b692e3ccc90f21..7eade843ad62e47f90dc06a4a1fb88b6d1c1a583 100644
+index ef29179988bb37e7ea441aa051b692e3ccc90f21..6c9641ed27722b5febd83f6e121df24d46b00067 100644
 --- a/testing/mochitest/browser-test.js
 +++ b/testing/mochitest/browser-test.js
+@@ -444,11 +444,11 @@ Tester.prototype = {
+       this.currentTest &&
+       window.gBrowser &&
+       AppConstants.MOZ_APP_NAME != "thunderbird" &&
+-      gBrowser.tabs.length > 1
++      gBrowser.tabs.length > 2
+     ) {
+       let lastURI = "";
+       let lastURIcount = 0;
+-      while (gBrowser.tabs.length > 1) {
++      while (gBrowser.tabs.length > 2) {
+         let lastTab = gBrowser.tabs[gBrowser.tabs.length - 1];
+         if (!lastTab.closing) {
+           // Report the stale tab as an error only when they're not closing.
 @@ -483,12 +483,12 @@ Tester.prototype = {
  
      // Replace the last tab with a fresh one

src/zen/moz.build

@@ -3,12 +3,8 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-
-BROWSER_CHROME_MANIFESTS += [
-    "tests/browser.toml",
-]
-
 DIRS += [
     "glance",
-    "mods"
+    "mods",
+    "tests",
 ]

src/zen/tests/.prettierignore

@@ -0,0 +1 @@
+run.sh

src/zen/tests/browser.toml

@@ -1,2 +0,0 @@
-["workspaces/browser_basic_workspaces.js"]
-["workspaces/browser_container_specific_essentials.js"]

src/zen/tests/container_essentials/browser.toml

@@ -0,0 +1,4 @@
+[DEFAULT]
+prefs = ["zen.workspaces.container-specific-essentials-enabled=true"]
+
+["browser_container_specific_essentials.js"]

src/zen/tests/container_essentials/browser_container_specific_essentials.js

@@ -3,10 +3,6 @@
 
 'use strict';
 
-add_setup(async function () {
-  ZenWorkspaces.containerSpecificEssentials = true;
-});
-
 add_task(async function test_Check_Creation() {
   await ZenWorkspaces.createAndSaveWorkspace('Container Profile 1', undefined, false, 1);
   const workspaces = await ZenWorkspaces._workspaces();
@@ -18,6 +14,10 @@ add_task(async function test_Check_Creation() {
   });
   ok(newTab, 'New tab should be opened.');
   gZenPinnedTabManager.addToEssentials(newTab);
+  ok(
+    newTab.hasAttribute('zen-essential') && newTab.parentNode.getAttribute('container') == '1',
+    'New tab should be marked as essential.'
+  );
   ok(
     gBrowser.tabs.find((t) => t.hasAttribute('zen-essential') && t.getAttribute('usercontextid') == 1),
     'New tab should be marked as essential.'

src/zen/tests/moz.build

@@ -0,0 +1,6 @@
+
+BROWSER_CHROME_MANIFESTS += [
+    "container_essentials/browser.toml",
+    "urlbar/browser.toml",
+    "workspaces/browser.toml",
+]

src/zen/tests/run.sh

@@ -1,13 +1,16 @@
 #!/bin/bash
 
+set -e
+
 # make sure we are on root
 if [ ! -f "package.json" ]; then
   echo "Please run this script from the root of the project"
   exit 1
 fi
 
-#npm run build:ui
-
 cd ./engine
-./mach mochitest zen/tests/ $@
+./mach mochitest $@ \
+  zen/tests/workspaces \
+  zen/tests/container_essentials \
+  zen/tests/urlbar
 cd ..

src/zen/tests/urlbar/browser.toml

@@ -0,0 +1,7 @@
+[DEFAULT]
+support-files = [
+  "head.js",
+  "!/browser/components/urlbar/tests/browser/head.js",
+]
+
+["browser_floating_urlbar.js"]

src/zen/tests/urlbar/browser_floating_urlbar.js

@@ -0,0 +1,48 @@
+/* Any copyright is dedicated to the Public Domain.
+   https://creativecommons.org/publicdomain/zero/1.0/ */
+
+'use strict';
+
+ChromeUtils.defineESModuleGetters(this, {
+  UrlbarTestUtils: 'resource://testing-common/UrlbarTestUtils.sys.mjs',
+});
+
+add_task(async function test_Floating_Urlbar() {
+  gURLBar.blur();
+
+  await SimpleTest.promiseFocus(window);
+  document.getElementById('Browser:OpenLocation').doCommand();
+  await UrlbarTestUtils.promiseAutocompleteResultPopup({
+    window,
+    waitForFocus: SimpleTest.waitForFocus,
+    value: 'http://example.com/',
+  });
+
+  ok(gURLBar.textbox.hasAttribute('zen-floating-urlbar'), 'URL bar should be in floating mode');
+});
+
+add_task(async function test_Click_Shoudnt_FLoat_Urlbar() {
+  gURLBar.blur();
+
+  await simulateClick(window);
+
+  await UrlbarTestUtils.promiseAutocompleteResultPopup({
+    window,
+    waitForFocus: SimpleTest.waitForFocus,
+    value: 'http://example.com/',
+  });
+
+  ok(!gURLBar.textbox.hasAttribute('zen-floating-urlbar'), 'URL bar should not be in floating mode');
+});
+
+add_task(async function test_Floating_Highlight_Everything() {
+  gURLBar.blur();
+
+  await SimpleTest.promiseFocus(window);
+  await selectWithMouseDrag(2, 5);
+  document.getElementById('Browser:OpenLocation').doCommand();
+
+  // Selection range
+  ok(gURLBar.selectionStart == 0, 'Selection start should be 0');
+  ok(gURLBar.selectionEnd == gURLBar.value.length, 'Selection end should be the length of the value');
+});

src/zen/tests/urlbar/head.js

@@ -0,0 +1,11 @@
+/* Any copyright is dedicated to the Public Domain.
+   https://creativecommons.org/publicdomain/zero/1.0/ */
+
+'use strict';
+
+function simulateClick(win = window) {
+  let target = win.gURLBar.inputField;
+  let promise = BrowserTestUtils.waitForEvent(target, 'click');
+  EventUtils.synthesizeMouseAtCenter(target, {});
+  return promise;
+}

src/zen/tests/workspaces/browser.toml

@@ -0,0 +1 @@
+["browser_basic_workspaces.js"]

src/zen/tests/workspaces/browser_basic_workspaces.js

@@ -24,5 +24,4 @@ add_task(async function test_Check_Creation() {
   ok(workspacesAfterRemove.workspaces.length === 1, 'One workspace should exist.');
   ok(workspacesAfterRemove.workspaces[0].uuid === currentWorkspaceUUID, 'The workspace should be the one we started with.');
   ok(gBrowser.tabs.length === 2, 'There should be one tab.');
-  BrowserTestUtils.removeTab(gBrowser.selectedTab);
 });

src/zen/workspaces/ZenWorkspaces.mjs

@@ -825,9 +825,9 @@ var ZenWorkspaces = new (class extends ZenMultiWindowFeature {
       delete this._initialTab;
     }
     if (this._tabToRemoveForEmpty) {
-      if (typeof this._tabToSelect === 'number' && this._tabToSelect >= 0) {
-        setTimeout(() => {
       const tabs = gBrowser.tabs.filter((tab) => !tab.collapsed && !tab.hasAttribute('zen-empty-tab'));
+      if (typeof this._tabToSelect === 'number' && this._tabToSelect >= 0 && tabs[this._tabToSelect]) {
+        setTimeout(() => {
           this.log(`Found tab to select: ${this._tabToSelect}, ${tabs.length}`);
           gBrowser.selectedTab = tabs[this._tabToSelect];
           this._removedByStartupPage = true;