mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-07-07 09:55:41 +02:00
Some checks are pending
/ release (push) Waiting to run
testing-integration / test-unit (push) Waiting to run
testing-integration / test-sqlite (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
This PR is part of https://codeberg.org/forgejo/forgejo/pulls/4767 It improves the signature handling: 1. move logic to a service (might be used from other services as well) 2. make a clear difference between ` ReqHTTPUserSignature` and `ReqHTTPUserOrInstanceSignature` 3. improve test ability (activitypub/client & distant_federation_server_mock Adjust instance actor 1. name & 2. webfinger ## Strategy for next PRs is Integration tests are in the driving seat. I will step by step add integration tests form original PR and add code required by the integration test changes. ## Meta Proposal howto process large PRs can be discussed here: https://codeberg.org/forgejo-contrib/federation/pulls/37 Current state with rendered diagrams can be found here: https://codeberg.org/meissa/federation/src/branch/merge-large-pr/doc/merge-large-pr.md Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8275 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de> Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
146 lines
4.7 KiB
Go
146 lines
4.7 KiB
Go
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package federation
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
"forgejo.org/models/forgefed"
|
|
"forgejo.org/models/repo"
|
|
"forgejo.org/models/user"
|
|
"forgejo.org/modules/activitypub"
|
|
fm "forgejo.org/modules/forgefed"
|
|
"forgejo.org/modules/log"
|
|
"forgejo.org/modules/validation"
|
|
context_service "forgejo.org/services/context"
|
|
)
|
|
|
|
// ProcessLikeActivity receives a ForgeLike activity and does the following:
|
|
// Validation of the activity
|
|
// Creation of a (remote) federationHost if not existing
|
|
// Creation of a forgefed Person if not existing
|
|
// Validation of incoming RepositoryID against Local RepositoryID
|
|
// Star the repo if it wasn't already stared
|
|
// Do some mitigation against out of order attacks
|
|
func ProcessLikeActivity(ctx *context_service.APIContext, form any, repositoryID int64) (int, string, error) {
|
|
activity := form.(*fm.ForgeLike)
|
|
if res, err := validation.IsValid(activity); !res {
|
|
return http.StatusNotAcceptable, "Invalid activity", err
|
|
}
|
|
log.Trace("Activity validated: %#v", activity)
|
|
|
|
// parse actorID (person)
|
|
actorURI := activity.Actor.GetID().String()
|
|
user, _, federationHost, err := FindOrCreateFederatedUser(ctx.Base, actorURI)
|
|
if err != nil {
|
|
ctx.Error(http.StatusNotAcceptable, "Federated user not found", err)
|
|
return http.StatusInternalServerError, "FindOrCreateFederatedUser", err
|
|
}
|
|
|
|
if !activity.IsNewer(federationHost.LatestActivity) {
|
|
return http.StatusNotAcceptable, "Activity out of order.", errors.New("Activity already processed")
|
|
}
|
|
|
|
// parse objectID (repository)
|
|
objectID, err := fm.NewRepositoryID(activity.Object.GetID().String(), string(forgefed.ForgejoSourceType))
|
|
if err != nil {
|
|
return http.StatusNotAcceptable, "Invalid objectId", err
|
|
}
|
|
if objectID.ID != fmt.Sprint(repositoryID) {
|
|
return http.StatusNotAcceptable, "Invalid objectId", err
|
|
}
|
|
log.Trace("Object accepted: %#v", objectID)
|
|
|
|
// execute the activity if the repo was not stared already
|
|
alreadyStared := repo.IsStaring(ctx, user.ID, repositoryID)
|
|
if !alreadyStared {
|
|
err = repo.StarRepo(ctx, user.ID, repositoryID, true)
|
|
if err != nil {
|
|
return http.StatusNotAcceptable, "Error staring", err
|
|
}
|
|
}
|
|
federationHost.LatestActivity = activity.StartTime
|
|
err = forgefed.UpdateFederationHost(ctx, federationHost)
|
|
if err != nil {
|
|
return http.StatusNotAcceptable, "Error updating federatedHost", err
|
|
}
|
|
|
|
return 0, "", nil
|
|
}
|
|
|
|
// Create or update a list of FollowingRepo structs
|
|
func StoreFollowingRepoList(ctx *context_service.Context, localRepoID int64, followingRepoList []string) (int, string, error) {
|
|
followingRepos := make([]*repo.FollowingRepo, 0, len(followingRepoList))
|
|
for _, uri := range followingRepoList {
|
|
federationHost, err := FindOrCreateFederationHost(ctx.Base, uri)
|
|
if err != nil {
|
|
return http.StatusInternalServerError, "Wrong FederationHost", err
|
|
}
|
|
followingRepoID, err := fm.NewRepositoryID(uri, string(federationHost.NodeInfo.SoftwareName))
|
|
if err != nil {
|
|
return http.StatusNotAcceptable, "Invalid federated repo", err
|
|
}
|
|
followingRepo, err := repo.NewFollowingRepo(localRepoID, followingRepoID.ID, federationHost.ID, uri)
|
|
if err != nil {
|
|
return http.StatusNotAcceptable, "Invalid federated repo", err
|
|
}
|
|
followingRepos = append(followingRepos, &followingRepo)
|
|
}
|
|
|
|
if err := repo.StoreFollowingRepos(ctx, localRepoID, followingRepos); err != nil {
|
|
return 0, "", err
|
|
}
|
|
|
|
return 0, "", nil
|
|
}
|
|
|
|
func DeleteFollowingRepos(ctx context.Context, localRepoID int64) error {
|
|
return repo.StoreFollowingRepos(ctx, localRepoID, []*repo.FollowingRepo{})
|
|
}
|
|
|
|
func SendLikeActivities(ctx context.Context, doer user.User, repoID int64) error {
|
|
followingRepos, err := repo.FindFollowingReposByRepoID(ctx, repoID)
|
|
log.Trace("Federated Repos is: %#v", followingRepos)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
likeActivityList := make([]fm.ForgeLike, 0)
|
|
for _, followingRepo := range followingRepos {
|
|
log.Trace("Found following repo: %#v", followingRepo)
|
|
target := followingRepo.URI
|
|
likeActivity, err := fm.NewForgeLike(doer.APActorID(), target, time.Now())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
likeActivityList = append(likeActivityList, likeActivity)
|
|
}
|
|
|
|
apclientFactory, err := activitypub.GetClientFactory(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
apclient, err := apclientFactory.WithKeys(ctx, &doer, doer.APActorID()+"#main-key")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for i, activity := range likeActivityList {
|
|
activity.StartTime = activity.StartTime.Add(time.Duration(i) * time.Second)
|
|
json, err := activity.MarshalJSON()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = apclient.Post(json, fmt.Sprintf("%v/inbox", activity.Object))
|
|
if err != nil {
|
|
log.Error("error %v while sending activity: %#v", err, activity)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|